Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to deprecated Kovan testnet #2635

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Sep 7, 2022

What was wrong?

With the Merge on the horizon, there are a bunch of testnets that will be deprecated and unmaintained.

  • Do we want to deprecate in v5 or remove altogether?

Related to Issue #2627

How was it fixed?

Removed Kovan auto provider. Rinkeby is not currently deprecated, but will not be updated for the Merge. I'll remove Rinkeby after the Merge happens.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@kclowes kclowes changed the title Remove references to deprecated testnets Remove references to deprecated Kovan testnet Sep 8, 2022
@kclowes kclowes marked this pull request as ready for review September 8, 2022 19:41
@kclowes kclowes mentioned this pull request Sep 8, 2022
1 task
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

Copy link
Contributor

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, no need to deprecate. Anyone still using it will figure it out pretty quick.

@kclowes kclowes merged commit 845bce4 into ethereum:master Sep 9, 2022
@kclowes kclowes deleted the remove-old-testnets branch September 9, 2022 16:25
kclowes added a commit to kclowes/web3.py that referenced this pull request Sep 14, 2022
kclowes added a commit that referenced this pull request Sep 14, 2022
* Remove references to deprecated Kovan testnet (#2635)

* Add newsfragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants